Skip to content

issue/DATAMONGO-1553 - Add $sortByCount aggregation stage. #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

issue/DATAMONGO-1553 - Add $sortByCount aggregation stage. #519

wants to merge 2 commits into from

Conversation

JeromeGuyon
Copy link

@JeromeGuyon JeromeGuyon commented Nov 29, 2017 •
edited
Loading

  • You have read the Spring Data contribution guidelines.
  • There is a ticket in the bug tracker for the project in our JIRA.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@JeromeGuyon JeromeGuyon changed the title issue/DATAMONGO-1553 issue/DATAMONGO-1553 - Add $sortByCount aggregation stage. Nov 30, 2017
mp911de pushed a commit that referenced this pull request Jan 8, 2018
@mp911de
DATAMONGO-1553 - Add $sortByCount aggregation stage.
7123f84 
Original pull request: #519.
mp911de added a commit that referenced this pull request Jan 8, 2018
@mp911de
DATAMONGO-1553 - Polishing.
9a13a3f 
Convert spaces to tabs. Reorder methods. Add tests, nullability annotations, author tags and slightly rearrange documentation. Migrate tests to AssertJ. Extend year range in license headers.

Original pull request: #519.
@mp911de
Copy link
Member

mp911de commented Jan 8, 2018

Thanks a lot for your contribution, the code looks pretty decent. That's now merged and polished.

@mp911de mp911de closed this Jan 8, 2018
@spring-projects-issues spring-projects-issues mentioned this pull request Dec 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JeromeGuyon @mp911de